https://issues.dlang.org/show_bug.cgi?id=24505

kinke <kinke@gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ImportC

--

https://issues.dlang.org/show_bug.cgi?id=24505

Tim <tim.dlang@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tim.dlang@t-online.de

--- Comment #1 from Tim <tim.dlang@t-online.de> ---
Maybe macros and normal symbols could be in different modules or mixin templates, so one is used by default, but it is still possible to get the other symbol explicitly. An example lowering could be:

```
struct stat { int x; };

void __stat(int x, int y);

mixin template __CMacros()
{
    // #define stat(x, y) __stat(x, y)
    void stat(T1, T2)(T1 x, T2 y)
    {
        __stat(x, y);
    }
}
mixin __CMacros!() __cmacros;
```

Now the compiler would prefer the struct, when using `stat`, but it would be possible to get the macro using `__cmacros.stat`.

--

https://issues.dlang.org/show_bug.cgi?id=24505

--- Comment #2 from kinke <kinke@gmx.net> ---
The mixin template could work (the module is the .c file), but I doubt it'd be a big improvement over simply ignoring a conflicting macro - as the importer needs to know about such (potentially platform-dependant) header details, i.e., what symbol might be a macro.

Another manual solution could be to skip the translation if the macro is undefined later via `#undef stat` - that would be doable in the .c file including the headers, without having to patch the original headers.

Note that the Postgres header
(https://github.com/postgres/postgres/blob/master/src/include/port/win32_port.h)
is actually even a bit worse, defining 3 `stat` 'symbols':
```
#define stat microsoft_native_stat
#include <sys/stat.h>
#undef stat
[…]
struct stat { … };
[…]
#define stat(path, sb)          _pgstat64(path, sb)
```

--

https://issues.dlang.org/show_bug.cgi?id=24505

kinke <kinke@gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |industry

--

https://issues.dlang.org/show_bug.cgi?id=24505

--- Comment #3 from anonymous4 <dfj1esp02@sneakemail.com> ---
Looks like a generic problem. How posix stat should work? It's defined as

struct stat { };
int stat(const char *pathname, struct stat *statbuf);

--

https://issues.dlang.org/show_bug.cgi?id=24505

--- Comment #4 from kinke <kinke@gmx.net> ---
(In reply to anonymous4 from comment #3)
> Looks like a generic problem. How posix stat should work?

It is a generic problem, one that we cannot solve elegantly in D/importC - we don't have an ugly 2-stage compilation like C(++), with preprocessor 'symbols'. But we need to be able to deal with this. In this concrete case, our interop code doesn't use `stat` in D at all, it's a totally uninteresting symbol, like ~99% of the C symbols dragged in by ~400k preprocessed lines.

If one indeed depended on the `stat` macro, a solution could be to add a little wrapper in the .c file, letting the preprocessor do its magic, and then aliasing `stat` to that custom wrapper in the .d file importing the .c file.

--

https://issues.dlang.org/show_bug.cgi?id=24505

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #5 from Dlang Bot <dlang-bot@dlang.rocks> ---
@kinke created dlang/dmd pull request #16396 "[stable] Fix bugzilla 24505 - ImportC: Function-like macros may collide with regular symbols" fixing this issue:

- Fix bugzilla 24505 - ImportC: Function-like macros may collide with regular symbols

https://github.com/dlang/dmd/pull/16396

--

https://issues.dlang.org/show_bug.cgi?id=24505

--- Comment #6 from Dlang Bot <dlang-bot@dlang.rocks> ---
@kinke created dlang/dmd pull request #16398 "[stable] Fix bugzilla 24505 - ImportC: Don't generate symbols for #undef'd macros" fixing this issue:

- Fix bugzilla 24505 - ImportC: Don't generate symbols for #undef'd macros

https://github.com/dlang/dmd/pull/16398

--

https://issues.dlang.org/show_bug.cgi?id=24505

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ibuclaw@gdcproject.org

--- Comment #7 from Iain Buclaw <ibuclaw@gdcproject.org> ---
By the way, the documentation already covers this with the following workaround:

```
typedef struct stat stat_t;
```

https://dlang.org/spec/importc.html#tag-symbols

--

https://issues.dlang.org/show_bug.cgi?id=24505

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #16398 "[stable] Fix bugzilla 24505 - ImportC: Don't generate symbols for #undef'd macros" was merged into stable:

- 60ae79810cc3aaa6687dccdfe80553fc896bed8d by Martin Kinkelin:
  Fix bugzilla 24505 - ImportC: Don't generate symbols for #undef'd macros

https://github.com/dlang/dmd/pull/16398

--